[SE-0101] Migration #125
Merged
[SE-0101] Migration #125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
| @@ -151,7 +151,7 @@ public struct DispatchData : RandomAccessCollection { | |||
|
|
|||
| /// Copy the contents of the data into a buffer. | |||
| /// | |||
| /// This function copies the bytes in `range` from the data into the buffer. If the count of the `range` is greater than `sizeof(DestinationType) * buffer.count` then the first N bytes will be copied into the buffer. | |||
| /// This function copies the bytes in `range` from the data into the buffer. If the count of the `range` is greater than `MemoryLayout<DestinationType>.size * buffer.count` then the first N bytes will be copied into the buffer. | |||
|
One small comment, LGTM otherwise. |
|
SHOOT! I didn't mean to merge this one. |
|
@rintaro , can you re-open? my apologies for the bogus early-merge. |
|
OK, I will reopen this with reflecting @gribozavr's comment. ( |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on swiftlang/swift#3854
SE-0101 removes
sizeof,sizeofValueand related functions from the stdlib.This PR is migrating them to newly introduced
MemoryLayout<T>values.